Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CategoryWidgetUI loading and no data #26

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

VictorVelarde
Copy link
Contributor

Issue reported by QA: "When I first access, I see the "loading skeleton" properly, but there is a blink and a "no data" message shows before showing the final content"

image

@VictorVelarde VictorVelarde force-pushed the fix-category-widget-alert branch from cdce34e to cff4cca Compare November 25, 2020 12:20
Copy link
Contributor

@neokore neokore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VictorVelarde VictorVelarde force-pushed the fix-category-widget-alert branch from cff4cca to f4f5a60 Compare November 26, 2020 10:28
@VictorVelarde VictorVelarde merged commit 3a7af1f into master Nov 26, 2020
@VictorVelarde VictorVelarde deleted the fix-category-widget-alert branch November 26, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants