Refactor useViewportFeatures #238
Conversation
Pull Request Test Coverage Report for Build 1573320190
💛 - Coveralls |
| setSourceViewportFeaturesReady(false); | ||
| executeTask(sourceId, Methods.LOAD_GEOJSON_FEATURES, { geojson }) | ||
| .then(() => setGeoJsonLoaded(true)) | ||
| .catch(throwError); |
There was a problem hiding this comment.
Same here. I don't mind a lot about then.catch, but what about the previous catch errors we had?
There was a problem hiding this comment.
I didn't see the custom throw. Agree that having it with then is more compact, thus probably more readable in this case.
There was a problem hiding this comment.
I agree with @VictorVelarde, about using await instead of then because it goes more in line with our style guides but it is a suggestion
|
@VictorVelarde error management isn't gone, still there. It was just generalised for having the same one in both hooks. |
|
We will check with @padawannn tomorrow before the merge |
| setSourceViewportFeaturesReady(false); | ||
| executeTask(sourceId, Methods.LOAD_GEOJSON_FEATURES, { geojson }) | ||
| .then(() => setGeoJsonLoaded(true)) | ||
| .catch(throwError); |
There was a problem hiding this comment.
I agree with @VictorVelarde, about using await instead of then because it goes more in line with our style guides but it is a suggestion
No description provided.