Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Histogram more flexible, accepting filters with null to select bars #234

Merged
merged 3 commits into from
Dec 4, 2021
Merged

Make Histogram more flexible, accepting filters with null to select bars #234

merged 3 commits into from
Dec 4, 2021

Conversation

padawannn
Copy link
Contributor

Histogram uses undefined value to save the value of its filters if you filter using the first column. The problem is that stringify an undefined value in array returns a null value so you cannot recover the selected bar from a stored configuration.

@coveralls
Copy link
Collaborator

coveralls commented Dec 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1539152152

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.058%
Totals Coverage Status
Change from base Build 1539147681: 0.0%
Covered Lines: 902
Relevant Lines: 1220
💛 - Coveralls

@padawannn padawannn requested a review from Josmorsot December 3, 2021 11:53
VictorVelarde
VictorVelarde approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Josmorsot
Josmorsot approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@Josmorsot Josmorsot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VictorVelarde VictorVelarde changed the title Histogram cannot recover selected bar from filters for certain values Make Histogram more flexible when using selected bars from filters with null Dec 3, 2021
@VictorVelarde VictorVelarde changed the title Make Histogram more flexible when using selected bars from filters with null Make Histogram more flexible, accepting filters with null to select bars Dec 3, 2021
@VictorVelarde VictorVelarde force-pushed the padawannn/histogram-fix branch from f155bee to 2c47dec Compare December 4, 2021 15:20
@VictorVelarde VictorVelarde merged commit 840ba92 into master Dec 4, 2021
@VictorVelarde VictorVelarde deleted the padawannn/histogram-fix branch December 4, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josmorsot Josmorsot Josmorsot approved these changes

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@padawannn @coveralls @VictorVelarde @Josmorsot