Remove lock in CategoryWidget if selected categories change #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
padawannn
commented
Nov 30, 2021
•
- For the category widget, unlock the widget if there are not a selected category
Pull Request Test Coverage Report for Build 1526760560
💛 - Coveralls |
| * @param {id} - sourceId of the filter to remove | ||
| * @param {owner} - widgetId of the filter to remove | ||
| */ | ||
| export const removeFilterByOwner = ({ id, owner }) => ({ |
There was a problem hiding this comment.
Owner is the internal name, but I would probably suggest something more clear for the end user, like 'removeFilterFromWidget ({ sourceId, widgetId })
There was a problem hiding this comment.
Also, I'm wondering if we need the sourceId, or if we can just iterate on all sources, without asking for the param, Does this make sense?
Can a widget affect several sources? I don't think so... right?
There was a problem hiding this comment.
You're right. I did it like this because it made my life easier for the integration with builder but it would be better to remove it
There was a problem hiding this comment.
Thinking better of it, this action is not necessary. Removed
e1c007c to
2fbbec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.