Fix animation duration not consistent in TimeSeriesWidget #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #188731: Animation duration is not consistent in TimeSeriesWidget. |
Pull Request Test Coverage Report for Build 1389571138
💛 - Coveralls |
| currentTimeWindow[0] + msTimeWindowStep, | ||
| currentTimeWindow[1] + msTimeWindowStep | ||
| ]; | ||
| if (currentTimeWindow[1] > data[data.length - 1].name) { |
There was a problem hiding this comment.
@Clebal what is data[data.length - 1].name) ? it looks something strange, comparing with .name...
There was a problem hiding this comment.
Yes, name is the date resulted from aggregation. I used name following the same prop name that in others widgets. But... I can change it if you want.
| @@ -44,7 +44,6 @@ const STEP_SIZE_RANGE_MAPPING = { | |||
| * @param {string} props.stepSize - Step applied to group the data. Must be one of those defined in `GroupDateTypes` object. | |||
| * @param {string[]} [props.stepSizeOptions] - Different steps that can be applied to group the data. If filled, an icon with a menu appears to change between steps. Every value must be one of those defined in `AggregationTypes` object. | |||
| * @param {string} [props.chartType] - Chart used to represent the time serie. Must be one of those defined in `TIME_SERIES_CHART_TYPES` object. | |||
| * @param {number} [props.duration] - Duration of the animation in milliseconds. 20s by default. | |||
There was a problem hiding this comment.
A doc update will be needed for this, @borja-munoz
…nsistent-in-timeserieswidget
VictorVelarde
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/cartoteam/story/188731