Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt executeSQL to the new SQL API v3 response #207

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Adapt executeSQL to the new SQL API v3 response #207

merged 3 commits into from
Oct 21, 2021

Conversation

eamador
Copy link
Contributor

@eamador eamador commented Oct 21, 2021

Story: https://app.shortcut.com/cartoteam/story/185801/adapt-the-executesql-function-to-the-new-sql-api-response

Adapt executeSQL to the new SQL API response which returns the data within rows

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #185775: Adapt workspace to new SQL API response.

Clebal
Clebal approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@Clebal Clebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@coveralls
Copy link
Collaborator

coveralls commented Oct 21, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1367966784

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.7%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-api/src/api/SQL.js 0 1 0.0%
Totals Coverage Status
Change from base Build 1367631632: 0.0%
Covered Lines: 885
Relevant Lines: 1167
💛 - Coveralls

@VictorVelarde VictorVelarde changed the title Adapt executeSQL to the new SQL API response Adapt executeSQL to the new SQL API v3 response Oct 21, 2021
VictorVelarde
VictorVelarde approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@VictorVelarde VictorVelarde merged commit 98e9b56 into master Oct 21, 2021
@VictorVelarde VictorVelarde deleted the feature/ch185775/adapt-executeSQL-to-new-api-response branch October 21, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clebal Clebal Clebal approved these changes

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eamador @coveralls @VictorVelarde @Clebal