Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning with icon legend #170

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Fix warning with icon legend #170

merged 3 commits into from
Oct 19, 2021

Conversation

aaranadev
Copy link
Contributor

I've removed the unused class in LegendIcon to remove warning console.

Story details: https://app.clubhouse.io/cartoteam/story/177765

@aaranadev aaranadev self-assigned this Sep 8, 2021
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #177765: Warning with icon legend.

@coveralls
Copy link
Collaborator

coveralls commented Sep 8, 2021

Pull Request Test Coverage Report for Build 1213397361

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 75.478%

Totals Coverage Status
Change from base Build 1210571782: 0.02%
Covered Lines: 711
Relevant Lines: 878

💛 - Coveralls

Copy link
Contributor

@borja-munoz borja-munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@VictorVelarde VictorVelarde changed the title Warning with icon legend Fix warning with icon legend Oct 14, 2021
@alasarr alasarr merged commit fdabb56 into master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants