Fix FormulaWidgetUI render when data is zero #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When data was 0, a render was not happening, leaving the widget with the previous value, causing a bug
Pull Request Test Coverage Report for Build 676585242
💛 - Coveralls |
a60efbc to
4c854df
Compare
VictorVelarde
commented
Mar 22, 2021
| @@ -3,15 +3,6 @@ import { render, screen } from '@testing-library/react'; | |||
| import FormulaWidgetUI from '../../src/widgets/FormulaWidgetUI'; | |||
| import { currencyFormatter } from './testUtils'; | |||
|
|
|||
| // Mock animations | |||
There was a problem hiding this comment.
I added this cause I noticed these tests were unstable, when using the real animation steps... I guess that adding the rerender + await removes the problem, but just for you to know
VictorVelarde
commented
Mar 22, 2021
| @@ -36,6 +27,12 @@ describe('FormulaWidgetUI', () => { | |||
| expect(await screen.findByText(DATA.value)).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| test('should render the current value', async () => { | |||
| const { rerender } = render(<FormulaWidgetUI data={1234} />); | |||
| rerender(<FormulaWidgetUI data={0} />); | |||
There was a problem hiding this comment.
@AdriSolid I was thinking about specific tests, in a different file, for animations, not the test on the widget removing the mock, but I guess this is also nice (if we don't need to use a mock anymore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When data was 0, a render was not happening, leaving the widget with the previous value, causing a bug