feat: add react-widget to storybook #120
Conversation
|
This pull request has been linked to Clubhouse Story #141940: Storybook detailed revision. |
Pull Request Test Coverage Report for Build 654980289Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| ['WrapperWidgetUI', 'FormulaWidgetUI', 'CategoryWidgetUI'] | ||
| ['FormulaWidget', 'CategoryWidget', 'HistogramWidget', 'PieWidget'], | ||
| 'WidgetsUI', | ||
| ['CategoryWidgetUI'] |
There was a problem hiding this comment.
@AdriSolid aren't we losing here the other UI widgets?
There was a problem hiding this comment.
Nop, that's actually the order, let me add same order as Widgets 👍
| @@ -2,36 +2,43 @@ import { Meta, Description } from '@storybook/addon-docs/blocks'; | |||
|
|
|||
| <Meta title="Introduction" /> | |||
|
|
|||
| # CARTO for React - UI Components | |||
| # CARTO for React - Widgets and UI Components | |||
| This storybook includes the UI Components for CARTO for React (@carto/react-ui). | |||
There was a problem hiding this comment.
This storybook includes the UI Components for CARTO for React (@carto/react-ui) and the powerful Widgets (@carto/react-widgets). Adding something like that?
There was a problem hiding this comment.
LGTM! Little change..
This storybook includes the UI Components (@carto/react-ui) and the powerful Widgets (@carto/react-widgets) for CARTO for React
What you think?
| @@ -21,6 +21,7 @@ import useWidgetLoadingState from './useWidgetLoadingState'; | |||
| * @param {string} [props.operationColumn] - Name of the data source's column to operate with. If not defined it will default to the one defined in `column`. | |||
| * @param {string} props.operation - Operation to apply to the operationColumn. Must be one of those defined in `AggregationTypes` object. | |||
| * @param {formatterCallback} [props.formatter] - Function to format each value returned. | |||
| * @param {Object} [props.labels] - Overwrite category labels | |||
| @@ -153,7 +153,8 @@ PieWidget.propTypes = { | |||
| formatter: PropTypes.func, | |||
| tooltipFormatter: PropTypes.func, | |||
| viewportFilter: PropTypes.bool, | |||
| onError: PropTypes.func | |||
| onError: PropTypes.func, | |||
| wrapperProps: PropTypes.object | |||
There was a problem hiding this comment.
we're we missing this? nice catch.
Pull Request Test Coverage Report for Build 657299563Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
For: https://app.clubhouse.io/cartoteam/story/141940/storybook-detailed-revision