[Pie widget] Removed unnecessary copies if not filterable (#815)

CartoDB · Dec 20, 2023 · df123bd · df123bd
1 parent 2a8b791
commit df123bd
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # CHANGELOG
 
 ## Not released
+- [Pie widget] Removed unnecessary copies if not filterable [#815](https://github.com/CartoDB/carto-react/pull/815)
 
 ## 2.3
 

diff --git a/packages/react-ui/src/widgets/PieWidgetUI/PieWidgetUI.js b/packages/react-ui/src/widgets/PieWidgetUI/PieWidgetUI.js
@@ -204,21 +204,23 @@ function PieWidgetUI({
 
   return (
     <>
-      <OptionsBar container>
-        <Typography variant='caption' color='textSecondary'>
-          {selectedCategories.length
-            ? intlConfig.formatMessage(
-                { id: 'c4r.widgets.pie.selectedItems' },
-                { items: selectedCategories.length }
-              )
-            : intlConfig.formatMessage({ id: 'c4r.widgets.pie.allSelected' })}
-        </Typography>
-        {selectedCategories.length > 0 && (
-          <Link variant='caption' onClick={handleClearSelectedCategories}>
-            {intlConfig.formatMessage({ id: 'c4r.widgets.pie.clear' })}
-          </Link>
-        )}
-      </OptionsBar>
+      {filterable && (
+        <OptionsBar container>
+          <Typography variant='caption' color='textSecondary'>
+            {selectedCategories.length
+              ? intlConfig.formatMessage(
+                  { id: 'c4r.widgets.pie.selectedItems' },
+                  { items: selectedCategories.length }
+                )
+              : intlConfig.formatMessage({ id: 'c4r.widgets.pie.allSelected' })}
+          </Typography>
+          {selectedCategories.length > 0 && (
+            <Link variant='caption' onClick={handleClearSelectedCategories}>
+              {intlConfig.formatMessage({ id: 'c4r.widgets.pie.clear' })}
+            </Link>
+          )}
+        </OptionsBar>
+      )}
 
       <ChartContent height={height} width={width}>
         <PieCentralText data={processedData} selectedCategories={selectedCategories} />