Skip to content

Commit

Permalink
Fix widget copies for 'All selected' (#809)
Browse files Browse the repository at this point in the history
  • Loading branch information
VictorVelarde authored Nov 30, 2023
1 parent 8818dd2 commit 765d101
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 11 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Added filterable prop to TimeSeriesWidget [#808](https://github.com/CartoDB/carto-react/pull/808)
- Fix dataSources store type [#807](https://github.com/CartoDB/carto-react/pull/807)
- Fix widget copies [#809](https://github.com/CartoDB/carto-react/pull/809)

## 2.3

Expand Down
2 changes: 1 addition & 1 deletion packages/react-ui/__tests__/widgets/BarWidgetUI.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('BarWidgetUI', () => {

test('all selected', () => {
render(<Widget />);
expect(screen.getByText(/All selected/)).toBeInTheDocument();
expect(screen.getByText(/All/)).toBeInTheDocument();
});

test('renders with stacked false', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('HistogramWidgetUI', () => {

test('all selected', () => {
render(<Widget />);
expect(screen.getByText(/All selected/)).toBeInTheDocument();
expect(screen.getByText(/All/)).toBeInTheDocument();
});

test('re-render with different data', () => {
Expand Down
6 changes: 3 additions & 3 deletions packages/react-ui/src/localization/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ const locales = {
search: 'Search'
},
bar: {
all: 'All selected',
all: 'All',
selectedItems: '{items, plural, one{# selected} other{# selected}}',
clear: 'Clear'
},
histogram: {
all: 'All selected',
all: 'All',
selectedItems: '{items} selected',
clear: 'Clear'
},
Expand Down Expand Up @@ -71,7 +71,7 @@ const locales = {
pie: {
clear: 'Clear',
selectedItems: '{items, plural, one{# selected} other{# selected}}',
allSelected: 'All selected'
allSelected: 'All'
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions packages/react-ui/src/localization/id.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ const locales = {
search: 'Cari'
},
bar: {
all: 'Semua yang dipilih',
all: 'Semua',
selectedItems: '{items, plural, one{# terpilih} other{# terpilih}}',
clear: 'Bersihkan'
},
histogram: {
all: 'Semua yang dipilih',
all: 'Semua',
selectedItems: '{items} terpilih',
clear: 'Bersihkan'
},
Expand Down Expand Up @@ -73,9 +73,9 @@ const locales = {
clear: 'Bersihkan',
selectedItems: '{items, plural, one{# terpilih} other{# terpilih}}',
allSelected: 'Semua terpilih'
},
},
},
}
}
}
}
};

export default locales;

0 comments on commit 765d101

Please sign in to comment.