Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update echarts to v5 #268

Merged
merged 4 commits into from
Sep 30, 2021
Merged

Update echarts to v5 #268

merged 4 commits into from
Sep 30, 2021

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Aug 5, 2021

No description provided.

@Clebal Clebal requested a review from VictorVelarde August 5, 2021 06:36
@vercel
Copy link

vercel bot commented Aug 5, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/2zD5wDCBrvPLp1aACxdmSC5JwGu3
✅ Preview: https://cra-template-carto-git-chore-update-echar-df0702-carto-frontend.vercel.app

@VictorVelarde VictorVelarde mentioned this pull request Sep 30, 2021
Merged
VictorVelarde
VictorVelarde approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested via linked packages, with current carto-react modules, upgraded to same versions

@VictorVelarde VictorVelarde merged commit f558ab3 into master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Clebal @VictorVelarde