refactor: rename bigquery source type #203
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/j6r0mspaf |
|
This pull request has been linked to Clubhouse Story #135148: rename source type in template. |
| @@ -5,7 +5,7 @@ const { promptArgs, readFile, getFiles } = require('../../promptUtils'); | |||
|
|
|||
| const VIEWS_DIR = 'components/views' | |||
|
|
|||
| const SOURCE_TYPES = ['sql', 'bq']; | |||
| const SOURCE_TYPES = ['sql', 'bigquery']; | |||
There was a problem hiding this comment.
IMO, if we have defined a type in the lib, we should export it and use them here, instead of a duplicated string
There was a problem hiding this comment.
You are right, didn't want to make this little 'breaking-change', going to add this then
| @@ -56,7 +56,7 @@ const prompt = async ({ prompter, args }) => { | |||
|
|
|||
| // Detect what kind of layer we need (CartoSQLLayer, CartoBQTilerLayer) | |||
| const selectedSourceFileContent = readFile(`src/data/sources/${answers.source_file}.js`); | |||
| const res = /(?:type: ')(?<type>sql|bq*)(?:')/g.exec(selectedSourceFileContent); | |||
| const res = /(?:type: ')(?<type>sql|bigquery*)(?:')/g.exec(selectedSourceFileContent); | |||
There was a problem hiding this comment.
If you make this dynamic, using the lib enum, you can use something like https://stackoverflow.com/questions/5090103/javascript-regexp-dynamic-generation-from-variables
And please double check the resulting regex, we already had an issue with this line
There was a problem hiding this comment.
As discussed, cannot require npm packages here, will wait for the creation of the lib cdn.
There was a problem hiding this comment.
I think we could just require from local node_modules with a relative path (from template) ... I'm gonna have a look
There was a problem hiding this comment.
...not so direct, so we'll skip this
There was a problem hiding this comment.
Seems a bit weird requiring a relative path from node_modules..
Rename BigQuery source type, from
bqtobigqueryFor: https://app.clubhouse.io/cartoteam/story/135148/rename-source-type-in-template
Related with: CartoDB/carto-react#97