Add a new forceOAuthLogin option to appSlice #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If configured via appSlice, a new fullscreen Login protects the whole app
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/l8u3ox0yl |
neokore
reviewed
Dec 10, 2020
| const [handleLogin] = useOAuthLogin(oauthApp, onParamsRefreshed); | ||
|
|
||
| return ( | ||
| <Container className={classes.containerWrapper}> |
There was a problem hiding this comment.
Maybe a Grid component here is better, unless you've found any issue to use it here
There was a problem hiding this comment.
Merging now, but I'll consider it when we apply the new design, thx!
neokore
reviewed
Dec 10, 2020
| const [handleLogin] = useOAuthLogin(oauthApp, onParamsRefreshed); | ||
|
|
||
| return ( | ||
| <Container className={classes.containerWrapper}> |
neokore
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forceOAuthLogin: if configured via appSlice, a new fullscreen Login protects the whole appThis is compatible with the (current) presence of a UserMenu, to Logout or Go to Dashboard.