Updated Sass version to 1.61.0 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @azizk, thanks for the PR! Can you please revert any changes other than those required to get dart_sass running on Linux again? That will make it much easier to review, thanks! If it's easier to close this PR and open a new one, that is fine too :) |
|
Sure, np! 😀 |
|
Hey @mcrumm, I extracted the unrelated refactorings from this branch and I'll make a different PR for those. Hope it's easier to review now. 🙂 |
|
Hi @mcrumm, hope you're not too busy. Any chance this can be merged in today or tomorrow? Thanks! 😃 |
* Added check: versions must be higher than 1.57.1 on Linux. * Renamed bin_path() to bin_paths(). * Renamed cmd() to run_cmd(). * Renamed path_exists?() to paths_exist?(). * Renamed bin_path(platform, base_path) to dest_bin_paths(...) and moved function to the top.
|
🍬 🍬 🍬 🍬 🍬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux package structure has changed and also has two binaries in the
src/folder now.dart-sass1.57.1 was the last version that you could configure for:dart_sasson Linux.With my changes you can use newer versions, but you won't be able to use earlier versions anymore.
I refactored the code somewhat for improvements and better readability. I'll revert specific changes if you don't like some. 🙂