Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed HMR #776

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Fixed HMR #776

merged 1 commit into from
Mar 17, 2021

Conversation

wdestin
Copy link
Contributor

@wdestin wdestin commented Mar 15, 2021

@wdestin wdestin requested a review from Betree March 15, 2021 23:38
Betree
Betree approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Betree Betree merged commit 8d55536 into staging Mar 17, 2021
@Betree Betree deleted the 47-add-hot-module-replacement branch March 17, 2021 20:05
@Betree
Copy link
Member

Betree commented Mar 17, 2021 •
edited
Loading

@wdestin I merged a bit quickly, but after more testing, it seems the page still reloads fully when a component is updated (I tested with AllPartners on the homepage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Betree Betree Betree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup HMR on frontend
2 participants
@wdestin @Betree