Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Additional Declared ROS Parameters in YAML File #80

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

alberthli
Copy link
Contributor

Sometimes, we may want to expose additional ROS parameters in an ObeliskNode. It may be convenient to set these directly in the master yaml file rather than supplying a path to some additional configuration file, especially if there are only a few parameters. This PR allows the end user to configure these parameters.

@alberthli alberthli requested a review from Zolkin1 July 23, 2024 00:34
Copy link
Collaborator

@Zolkin1 Zolkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. verified all three examples locally and all worked.

@alberthli alberthli merged commit cab333e into main Jul 23, 2024
1 check passed
@alberthli alberthli deleted the configure-ros-params-yaml branch July 23, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants