Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch OBELISK_BUILD_X vars for local install #112

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

alberthli
Copy link
Contributor

@alberthli alberthli commented Aug 7, 2024

There seems to be a bug where leap or zed ros packages are built in local downstream installs of obelisk even when those flags are not passed to the setup script. This PR is an attempt to fix it.

Changes:

  • Re-source the bashrc at the end of the user setup script. We need to re-source after after running the setup script to update the bash aliases. Docker does not need to re-source the bashrc, so we first check if the source script is there and skip if its not.
  • Added obk-build --verbose flag
  • Solved leap and zed build when setup flag was false, this is now fixed by changing the cmake parsing code. Currently we have opted for a verbose, but correct cmake parsing method.

Notes:

  • Removed $ in front of ENV in the cmake DEFINED call. When accessing the env variable, you do need the $.

@alberthli alberthli marked this pull request as ready for review August 7, 2024 00:05
@alberthli alberthli requested a review from Zolkin1 August 7, 2024 00:05
Copy link
Collaborator

@Zolkin1 Zolkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zolkin1 Zolkin1 merged commit 6af91e2 into main Aug 7, 2024
1 check passed
@Zolkin1 Zolkin1 deleted the patch-obelisk-build-x-vars branch August 7, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants