Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Commit

Permalink
Merge pull request #2 from tonypearson/tonypearson-patch-2
Browse files Browse the repository at this point in the history
Update CONTRIBUTING.md
  • Loading branch information
tonypearson authored Jul 7, 2020
2 parents 5ff6d67 + 158f33e commit 0f3dfa1
Showing 1 changed file with 47 additions and 17 deletions.
64 changes: 47 additions & 17 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,45 +1,74 @@
# Contributing

When contributing a major change to this repository, please first discuss the change you wish to make via an [issue](contributing/ISSUES.md) or via
[Slack in the #emb-race-cfc-challenge channel](https://code-and-response.slack.com/join/shared_invite/enQtNzUzOTAzNDE3MTM4LWM4M2VlOTA3OWNjMjY0ZTI4MjQ2OTBjYjYwNmQ1NTdhYjZhODE5NjFkN2QyNmRkNDI5OTFlZmVjYTFhMmMwYmU). Minor issues can simply be addressed by sending by a pull request.
When contributing a major change to this repository, please first discuss the
change you wish to make via an [issue](contributing/ISSUES.md) or via
[Slack in the #emb-race-cfc-challenge channel]
(https://code-and-response.slack.com/join/shared_invite/enQtNzUzOTAzNDE3MTM4LWM4M2VlOTA3OWNjMjY0ZTI4MjQ2OTBjYjYwNmQ1NTdhYjZhODE5NjFkN2QyNmRkNDI5OTFlZmVjYTFhMmMwYmU).
Minor issues can simply be addressed by sending by a pull request.

Please note we have a [Code of Conduct](CODE_OF_CONDUCT.md), please follow it in all your interactions with the project and its community.
Please note we have a [Code of Conduct](CODE_OF_CONDUCT.md), please follow it
in all your interactions with the project and its community.

## Creating a GitHub account

In order to open issues, submit pull requests, or edit the wiki you'll need a [GitHub account](https://github.com/join). Whether you use a personal email address or an IBM address, you can then [link it back to your IBM-internal GitHub Enterprise account](https://gh-user-map.dal1a.cirrus.ibm.com/).
In order to open issues, submit pull requests, or edit the wiki you'll need a
[GitHub account](https://github.com/join). Whether you use a personal email
address or an IBM address, you can then
[link it back to your IBM-internal GitHub Enterprise account]
(https://gh-user-map.dal1a.cirrus.ibm.com/).

## Opening issues

Issues are for suggesting and discussing changes to this solution starter. You don't have to be technical to add your thoughts here. [You can suggest a change, add a view point, or spark a discussion](issues).
Issues are for suggesting and discussing changes to this solution starter.
You don't have to be technical to add your thoughts here.
[You can suggest a change, add a view point, or spark a discussion](issues).

## Submitting pull requests

If you have a specific change you want to contribute, whether code or documentation, you can fork this repository and submit a pull request with the concrete change.
If you have a specific change you want to contribute, whether code or
documentation, you can fork this repository and submit a pull request with
the concrete change.

## Editing the wiki

You are also free to [provide documentation or notes through the wiki](wiki). The changes there can be merged into this repository directly, or they may serve as outside documentation.
You are also free to [provide documentation or notes through the wiki](wiki).
The changes there can be merged into this repository directly, or they may
serve as outside documentation.

## Examples

### An example of adding an idea or suggestion 

After reading the solution starter documentation in the [README](README.md) file, Ndu notices that the repository doesn't have a link to an important web page on the topic. After discussion the omission on Slack, folks agree that it would be an important and relevant addition to the repo. He then opens a GitHub issue summarizing the web page, and where a link to the web page should be included on the README or other sub pages. 
After reading the solution starter documentation in the [README](README.md)
file, Ndu notices that the repository doesn't have a link to an important web
page on the topic. After discussion the omission on Slack, folks agree that
it would be an important and relevant addition to the repo. He then opens a
GitHub issue summarizing the web page, and where a link to the web page should
be included on the README or other sub pages. 

At that point there are a couple potential ways to get the link included:
* One of the theme team leaders with direct write access to the repository could make the proposed change
* Or, Ndu can fork the repository, make the proposed change in his copy, link to the issue, and send a pull request.
* Or, another person all together can proactively make the pull request on his behalf.
* One of the theme team leaders with direct write access to the repository
could make the proposed change
* Or, Ndu can fork the repository, make the proposed change in his copy,
link to the issue, and send a pull request.
* Or, another person all together can proactively make the pull request on
his behalf.
* The theme team leaders can accept the change

### An example of providing working code
Sasha has an idea for a Node-RED flow that gathers data from several datasets on the Internet that have APIs. She writes a Node-RED flow locally or on the IBM Cloud. When she's done, she documents it, creates a demo video, and wants to contribute it to the repository.
Sasha has an idea for a Node-RED flow that gathers data from several datasets
on the Internet that have APIs. She writes a Node-RED flow locally or on the
IBM Cloud. When she's done, she documents it, creates a demo video, and wants
to contribute it to the repository.

At that point there are a couple potential ways to get the code for the Node-RED flow included:
* Sasha can fork the repository, make the proposed change in her copy, link to the issue, and send a pull request.
* Since it might be more complex of a change, there may be discussion about the pull request in GitHub
* The theme team leaders can accept the change, including any changes that result from the discussion
At that point there are a couple potential ways to get the code for the
Node-RED flow included:
* Sasha can fork the repository, make the proposed change in her copy, link to
the issue, and send a pull request.
* Since it might be more complex of a change, there may be discussion about
the pull request in GitHub
* The theme team leaders can accept the change, including any changes that
result from the discussion



Expand All @@ -53,4 +82,5 @@ At that point there are a couple potential ways to get the code for the Node-RED

## Support

If you have any questions about how to contribute, reach out to the team through the [support resources](SUPPORT.md).
If you have any questions about how to contribute, reach out to the team
through the [support resources](SUPPORT.md).

0 comments on commit 0f3dfa1

Please sign in to comment.