Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PredictionResult: do not store out_to_in_trans #367

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Oct 9, 2024

This is necessary to allow serialization of Sample objects (e.g. when passing results through a Queue to another process). Storing the callable (which contains local lambda expressions) in the object would prevent pickling and was not necessary for the calculation of the x positions running once.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@f0139d6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
calamari_ocr/ocr/predict/params.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             master    #367   +/-   ##
========================================
  Coverage          ?   0.00%           
========================================
  Files             ?     129           
  Lines             ?    6861           
  Branches          ?       0           
========================================
  Hits              ?       0           
  Misses            ?    6861           
  Partials          ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bertsky bertsky merged commit 54875f2 into Calamari-OCR:master Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants