Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add motor slewing back in #104

Closed
benjaminwp18 opened this issue Oct 14, 2024 · 3 comments · Fixed by #110 or #134
Closed

[FEATURE] Add motor slewing back in #104

benjaminwp18 opened this issue Oct 14, 2024 · 3 comments · Fixed by #110 or #134
Assignees
Milestone

Comments

@benjaminwp18
Copy link
Contributor

We wrote a motor slewing/ramping branch at competition (smooth_thrusters), but it never got merged. Merge main into it and make any changes necessary. Would it be better to put the slewing in multiplexer.py where the throttling is, so it will apply to all control and not just the Xbox controller?

@github-project-automation github-project-automation bot moved this to Todo in ROV 2025 Oct 14, 2024
@benjaminwp18 benjaminwp18 added this to the Preseason milestone Oct 14, 2024
@benjaminwp18 benjaminwp18 added the good first issue Good for newcomers label Oct 14, 2024
@InvincibleRMC
Copy link
Member

@benjaminwp18 I thought the plan was to try #16 first?

@benjaminwp18
Copy link
Contributor Author

It was, but our boy was browning out a lot yesterday, and I think it'd be good to get slewing in now so we know it still works, just in case Pixhawk stuff fails.

@InvincibleRMC
Copy link
Member

It was, but our boy was browning out a lot yesterday, and I think it'd be good to get slewing in now so we know it still works, just in case Pixhawk stuff fails.

pilot skill issue.

@benjaminwp18 benjaminwp18 mentioned this issue Nov 2, 2024
5 tasks
@benjaminwp18 benjaminwp18 linked a pull request Nov 2, 2024 that will close this issue
5 tasks
@benjaminwp18 benjaminwp18 self-assigned this Nov 23, 2024
@benjaminwp18 benjaminwp18 removed the good first issue Good for newcomers label Jan 17, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in ROV 2025 Jan 17, 2025
@benjaminwp18 benjaminwp18 reopened this Jan 17, 2025
@benjaminwp18 benjaminwp18 moved this from Done to In progress in ROV 2025 Jan 20, 2025
@benjaminwp18 benjaminwp18 mentioned this issue Jan 20, 2025
5 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ROV 2025 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants