Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matchers should return empty for null #29

Closed
rodwiddowson opened this issue Sep 10, 2019 · 2 comments
Closed

Matchers should return empty for null #29

rodwiddowson opened this issue Sep 10, 2019 · 2 comments

Comments

@rodwiddowson
Copy link

For completeness I'll pop this in, it was reported here.

The getMatchingValues method in AttributeInOIDCRequestedClaimsMatcher returns null quite a lot.

the filters (both matchers and policy) return a tristate in which we distinguish between "worked but nothing resulted" and "failed". For the former case you need to return an empty set for the latter null.

This is a signal to the upper layers to "do the right thing" depending on whether this is a deny rule (in which case failure means "deny everything") or an accept rule (in which case failure means "accept nothing").

I'm sure you've seen the case, this is just FWIW

@hjmikkon
Copy link
Collaborator

Thanks, this is clearly a bug on our side and will be fixed to the next release.

@hjmikkon
Copy link
Collaborator

hjmikkon commented Feb 7, 2020

Fix released in v1.1.0.

@hjmikkon hjmikkon closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants