Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/saved objects info #92

Merged
merged 13 commits into from
Nov 10, 2020
Merged

Feature/saved objects info #92

merged 13 commits into from
Nov 10, 2020

Conversation

saulipurhonen
Copy link
Contributor

Description

Added list for submissions in Add Objects -step. Possibility to delete objects from list.

Related issues

Fixes #68

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • List submissions by object type
  • Enable deletion from both state and database
  • Show "Added!" toast after successful object save

Testing

  • Integration Tests

@saulipurhonen saulipurhonen added the enhancement New feature or request label Nov 9, 2020
@saulipurhonen saulipurhonen self-assigned this Nov 9, 2020
@saulipurhonen saulipurhonen linked an issue Nov 9, 2020 that may be closed by this pull request
Implement showing info about saved objects in wizard #68
Closed
@saulipurhonen
Copy link
Contributor Author

Note: Objects list isn't responsive just yet.

@lilachic
Copy link
Contributor

Looks ok for me. Just something in appearance, in narrow screen the delete x is rendered on top of the list text. In the List header there is "Submitted study forms" here Submitted study items. If I also upload XML files I don't detect which are which, maybe the ID tells.

blankdots
blankdots approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks ok. We can touch up any css in feature version

@blankdots
Copy link
Contributor

blankdots commented Nov 10, 2020 •
edited
Loading

In the List header there is "Submitted study forms" here Submitted study items. If I also upload XML files I don't detect which are which, maybe the ID tells.

@lilachic good point can you add an issue about it ?

@blankdots blankdots merged commit 7c583bf into develop Nov 10, 2020
@blankdots blankdots deleted the feature/saved-objects-info branch November 10, 2020 14:58
@lilachic lilachic mentioned this pull request Nov 11, 2020
Closed
@blankdots blankdots mentioned this pull request Nov 23, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilachic lilachic lilachic approved these changes

@blankdots blankdots blankdots approved these changes

@csc-jm-zz csc-jm-zz Awaiting requested review from csc-jm-zz

Assignees

@saulipurhonen saulipurhonen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement showing info about saved objects in wizard
3 participants
@saulipurhonen @lilachic @blankdots