Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/update Post and Patch objects and draft objects #672

Merged
merged 6 commits into from
Feb 28, 2022
Merged

Bugfix/update Post and Patch objects and draft objects #672

merged 6 commits into from
Feb 28, 2022

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Feb 23, 2022 •
edited
Loading

Description

  • Updating posting and patching objects and draft objects according to new changes in backend.

Related issues

Fixes #626 which is related to backend PR: CSCfi/metadata-submitter#341

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Added folderId as query params folder={folderId} to POST request in service/objectAPI and service/draftAPI
  • Removed patching folder when modifying an existing object or draft object
  • Removed addObjectToFolder and addDraftsToFolder in wizardSubmissionFolderSlice.tsx
  • Updated documentation
  • Updated Changelog
  • Changed e2e test to current backend PR branch

Testing

  • Current unit test and integration tests should cover this

@hannyle hannyle changed the title Bugfix/post and patch objects and drafts Bugfix/post and patch objects and draft objects Feb 23, 2022
@hannyle hannyle changed the title Bugfix/post and patch objects and draft objects Bugfix/update Post and Patch objects and draft objects Feb 23, 2022
@hannyle hannyle self-assigned this Feb 23, 2022
@hannyle hannyle added bug Something isn't working enhancement New feature or request frontend frontend issue labels Feb 23, 2022
@hannyle hannyle added this to the Open Beta milestone Feb 23, 2022
@hannyle hannyle linked an issue Feb 23, 2022 that may be closed by this pull request
Remove patching of object to folder from frontend #626
Closed
@hannyle hannyle requested review from blankdots and rquazi February 23, 2022 10:50
@hannyle hannyle force-pushed the bugfix/post-and-patch-objects-and-drafts branch from a2fc60e to aa881b9 Compare February 24, 2022 07:02
@hannyle hannyle force-pushed the bugfix/post-and-patch-objects-and-drafts branch from 715513e to 992deb9 Compare February 28, 2022 09:17
@hannyle hannyle merged commit acd044a into develop Feb 28, 2022
@hannyle hannyle deleted the bugfix/post-and-patch-objects-and-drafts branch February 28, 2022 10:07
@blankdots blankdots mentioned this pull request Apr 7, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankdots blankdots blankdots approved these changes

@rquazi rquazi Awaiting requested review from rquazi

Assignees

@hannyle hannyle

Labels
bug Something isn't working enhancement New feature or request frontend frontend issue
Projects
None yet
Milestone
Open Beta
Development

Successfully merging this pull request may close these issues.

Remove patching of object to folder from frontend
2 participants
@hannyle @blankdots