Bugfix/invalid field format #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hannyle
approved these changes
Feb 8, 2022
blankdots
approved these changes
Feb 8, 2022
|
changelog maybe ? |
I'll rebase and add to changelog when #624 is merged |
9d7ad9a to
81d7b35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All string typed numbers (except
telephoneNumberfield) were cast as numbers when passing data to request payload. This resulted in behavior where in some occasions those value types were incorrect and raised validation issues in the backend.Related issues
Fixes #660
Type of change
Changes Made
Testing
Active tests should be sufficient since we have test cases for both Sample / TaxonId (integer type) and DAC / Contact form / Telephone number (string type with integer value).