Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/autocomplete full name #529

Merged
merged 4 commits into from
Nov 10, 2021
Merged

Feature/autocomplete full name #529

merged 4 commits into from
Nov 10, 2021

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Nov 8, 2021 •
edited
Loading

Description

In DOI form, creators' and contritbutors' full name should be autofilled from last name and given name

Related issues

Closes #501

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • watch changes from lastName and givenName fields to fill in the fullName
  • Disable the field fullName
  • Add getPathName function to be reused to JSONSchemaUtils
  • Update cypress test for autofilling fullName

Testing

  • Unit Tests

@hannyle hannyle added the enhancement New feature or request label Nov 8, 2021
@hannyle hannyle self-assigned this Nov 8, 2021
saulipurhonen
saulipurhonen approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@saulipurhonen saulipurhonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as described.

blankdots
blankdots approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove some commented code, but otherwise LGTM
also as there were some comments about familyName vs lastName maybe we keep them consistent as the JSON schema and have them all as familyName (we changed all to that with CSCfi/metadata-submitter#279)

cypress/integration/doiForm.spec.js Outdated Show resolved Hide resolved
src/components/NewDraftWizard/WizardForms/WizardJSONSchemaParser.js Outdated Show resolved Hide resolved
@hannyle hannyle merged commit 3794e63 into develop Nov 10, 2021
@hannyle hannyle deleted the feature/autocomplete-full-name branch November 10, 2021 11:20
@blankdots blankdots mentioned this pull request Apr 7, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulipurhonen saulipurhonen saulipurhonen approved these changes

@blankdots blankdots blankdots approved these changes

@lilachic lilachic Awaiting requested review from lilachic

Assignees

@hannyle hannyle

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannyle @blankdots @saulipurhonen