Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved json forms #52

Merged
merged 30 commits into from
Aug 10, 2020
Merged

Improved json forms #52

merged 30 commits into from
Aug 10, 2020

Conversation

otahontas
Copy link
Contributor

@otahontas otahontas commented Aug 7, 2020 •
edited
Loading

Description

This PR will include a lot of improvements for json forms performance- and feature-wise.

Related issues

#53 #43 #47

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

  • Moved away from Formik to react-hook-forms (react-hook-form.com/)
  • rewrote jsonschema parser to handle react-hook-form -based fields
  • added support for arrays inside arrays
  • added ajv-based validation of fields, so now validation is exactly the same in frontend and in backend
  • added support for posting json form data to backend

Testing

  • Needs testing

otahontas and others added 30 commits August 6, 2020 13:57
@otahontas
Add rendering of objects inside arrays
a8edf50
@otahontas
Optimize field rendering with FastFields
ce50c05
@otahontas
Change fieldprop type
c985e0b
@otahontas
Fix recursion logic for initialvalue parsing
2ae63b7
@otahontas
Streamline field recursiong, add support for arrays inside arrays
5ddbe01
@otahontas
Add form section divs, remove unnecessary code
1b47596
@otahontas
Add flow types and write components as real react components
2f40854
@otahontas
Add more type checks, fix some type errors
2bd32a0
@otahontas
Fix some form layout issues
c0bb7e4
@otahontas
Add react-hook-forms library
ae3765f 
Formiks controlled field components make rendering really slow with
large forms (such as experiment, analysis). React-hook-forms is
based on uncontrolled field components, so it should make forms
better performance-wise.
@otahontas
Add react-hook-forms based parsing for some fields
d9fb0a9
@otahontas
Add support for enumerative arrays
a8d0ef0
@otahontas
Add array support for react-hook-forms, remove Formik-forms
64b7ffa
@otahontas
Add formcontext to avoid prop passing
aec71d2
@otahontas
Remove unused files and tests
a6e77d9
@otahontas
Add some type hints
a6974fe
@otahontas
Remove unused npm packages
9002de9
@otahontas
Add joi validator and enjoi converter packages
d7258a7
@otahontas
Update enjoi to download directly from master
3297fd0 
The most recent version in npm doesn't follow correct Joi library
upstream, so this is just a workaround. Fix this when new version
of enjoi gets released!
@otahontas
Make dereferencing a pure function, import joi and enjoi to form comp…
47e4ba3 
…onent
@otahontas
Add joi error resolver
6fa530b
@otahontas
Add error checks for different field types
a4eb2f9
@otahontas
Add support for showing required fields
cf4ba4c
@otahontas
Remove enjoi and joi in favor of ajv validation
d169ed4
@otahontas
Add ajv-based validation
63cfdaf
@otahontas
Fix unnecessary use of computed properties with literals
c851872
@otahontas
Fix user being allowed to submit forms without required fields filled
a6c9038
@otahontas
Refactor some duplicate components
ba094da
@otahontas
Add support for posting forms to backend
2738e64
@otahontas
Don't use for-loops when recursing
49c0bbb
@otahontas otahontas self-assigned this Aug 10, 2020
@otahontas otahontas marked this pull request as ready for review August 10, 2020 06:51
blankdots
blankdots approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems to be there as pointed out, would need a bit of redesign on the form side as now for some reason the save button looks misplaced.

approving as is. as it is relevant for moving forward

@otahontas otahontas merged commit 6038f76 into develop Aug 10, 2020
@otahontas otahontas deleted the feature/improve-json-forms branch August 10, 2020 10:00
@otahontas otahontas mentioned this pull request Aug 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankdots blankdots blankdots approved these changes

@csc-jm-zz csc-jm-zz Awaiting requested review from csc-jm-zz

Assignees

@otahontas otahontas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otahontas @blankdots