-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/json schema form tests #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice to me!
I'm not sure if we have covered all the cases in forms yet but at least I have seen most of them.
I don't see the test case for enum
in jest
test for example, or is it already covered in cypress test (?)
And I think it's good also to have some comments (in jest
test) about which case/form as an example to be easier to catch up later.
There can be some underlying special cases but I think we can add those later if found.
Good call, missed that one entirely. Introduced test for
Very good point. Added some comments to latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have covered most of the cases for now.
If later any specific cases still need to be added, we could have them in another PR.
Description
Jest tests for form rendering from custom schema.
Related issues
Closes #54
Type of change
Changes Made
Testing