Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/json schema form tests #453

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Conversation

saulipurhonen
Copy link
Contributor

@saulipurhonen saulipurhonen commented Sep 15, 2021

Description

Jest tests for form rendering from custom schema.

Related issues

Closes #54

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Created custom schema with different field types
  • Test form rendering
  • Test field rendering

Testing

  • Integration Tests

@saulipurhonen saulipurhonen changed the base branch from master to develop September 15, 2021 11:45
@saulipurhonen saulipurhonen self-assigned this Sep 16, 2021
@saulipurhonen saulipurhonen added the enhancement New feature or request label Sep 16, 2021
@saulipurhonen saulipurhonen added this to the Open Beta milestone Sep 16, 2021
Copy link
Contributor

@hannyle hannyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice to me!

I'm not sure if we have covered all the cases in forms yet but at least I have seen most of them.
I don't see the test case for enum in jest test for example, or is it already covered in cypress test (?)

And I think it's good also to have some comments (in jest test) about which case/form as an example to be easier to catch up later.

@saulipurhonen
Copy link
Contributor Author

I'm not sure if we have covered all the cases in forms yet but at least I have seen most of them.

There can be some underlying special cases but I think we can add those later if found.

I don't see the test case for enum in jest test for example, or is it already covered in cypress test (?)

Good call, missed that one entirely. Introduced test for enum field just now.

And I think it's good also to have some comments (in jest test) about which case/form as an example to be easier to catch up later.

Very good point. Added some comments to latest commit.

Copy link
Contributor

@hannyle hannyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have covered most of the cases for now.
If later any specific cases still need to be added, we could have them in another PR.

@hannyle hannyle merged commit 57f89a6 into develop Sep 21, 2021
@hannyle hannyle deleted the feature/JSON-schema-form-tests branch September 21, 2021 11:30
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests for JSON schema based forms
3 participants