Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/distinguish linking accession ids #449

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Feature/distinguish linking accession ids #449

merged 4 commits into from
Sep 8, 2021

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Sep 7, 2021 •
edited
Loading

Description

Title is made as a required field in all forms and make it easier for users to distinguish among different linking accessionIds by their Title.

Related issues

#436

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Make Title as required field in forms, except for DAC form which will have Contact as required field
  • Attach Title to linking accessionIds
  • Update cypress test for Title as required field and new linking accessionIds structure

Testing

  • Integration Tests

@hannyle hannyle self-assigned this Sep 7, 2021
@hannyle hannyle added the enhancement New feature or request label Sep 7, 2021
@hannyle hannyle added this to the Open Beta milestone Sep 7, 2021
@hannyle hannyle linked an issue Sep 7, 2021 that may be closed by this pull request
Distinguish between accession ids #436
Closed
saulipurhonen
saulipurhonen approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@saulipurhonen saulipurhonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

References with linkable accession id's display correctly. Also DAC reference works as it should.

@lilachic
Copy link
Contributor

lilachic commented Sep 8, 2021

Looks good to me, just I seem to get undefined visible in accessionid list ?
Screenshot 2021-09-08 at 10 27 02

@hannyle
Copy link
Contributor Author

hannyle commented Sep 8, 2021

Looks good to me, just I seem to get undefined visible in accessionid list ?
Screenshot 2021-09-08 at 10 27 02

what kind of accessionIds list you had (belong to which object type) ?

@lilachic
Copy link
Contributor

lilachic commented Sep 8, 2021

That came from experiment form, not sure what was the linked object type.

lilachic
lilachic approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that was old manual test data. But something we might want to keep an eye on.

@hannyle hannyle merged commit 30b9fd8 into develop Sep 8, 2021
@hannyle hannyle deleted the feature/distinguish-linking-accessionIds branch September 8, 2021 10:19
@blankdots blankdots mentioned this pull request Apr 7, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulipurhonen saulipurhonen saulipurhonen approved these changes

@lilachic lilachic lilachic approved these changes

Assignees

@hannyle hannyle

Labels
enhancement New feature or request
Projects
None yet
Milestone
Open Beta
Development

Successfully merging this pull request may close these issues.

Distinguish between accession ids
3 participants
@hannyle @lilachic @saulipurhonen