Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update packages and package-lock.json #311

Merged
merged 3 commits into from
May 19, 2021
Merged

update packages and package-lock.json #311

merged 3 commits into from
May 19, 2021

Conversation

blankdots
Copy link
Contributor

@blankdots blankdots commented May 17, 2021 •
edited
Loading

Description

Packages got mixed up and somewhat out of date. this also fixes the security issues that appear in the package installation.

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Updating packages

Changes Made

  1. Reconstructed the package-lock.json to eliminate any unnecessary dependencies
  2. removed jest-environment-jsdom-sixteen as it is included in jest
  3. pinned jest to 2.26.0 as it created conflicts with other dependecies
  4. updated npm version in e2e tests

Testing

  • Tests do not apply

Mentions

DO THIS to test:
Remove node_modules and do npm install to get the correct package installations

@blankdots blankdots force-pushed the update/packages branch 3 times, most recently from b777692 to d916e75 Compare May 18, 2021 05:42
@blankdots blankdots self-assigned this May 18, 2021
@blankdots blankdots added the bug Something isn't working label May 18, 2021
@blankdots blankdots marked this pull request as ready for review May 18, 2021 06:13
@blankdots blankdots merged commit fa5b85f into develop May 19, 2021
@blankdots blankdots deleted the update/packages branch May 19, 2021 06:58
@blankdots blankdots mentioned this pull request Aug 11, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilachic lilachic lilachic approved these changes

@hannyle hannyle hannyle approved these changes

@saulipurhonen saulipurhonen Awaiting requested review from saulipurhonen

Assignees

@blankdots blankdots

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blankdots @hannyle @lilachic