Higlight required fields

[saulipurhonen]

Description

All required fields are not highlighted and this can confuse user.

Related issues

Closes #291

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Changes Made

• Handle sections that are required but don't contain any required fields
• Highlight required text areas
• Highlight required One Of fields
• Asterisk after FieldArray heading if section is required

Testing

• Tests do not apply

[saulipurhonen]

Found some issues where non-required field were handled as required.
There's also some fields that need to be required but nesting loses the required attribute.

[saulipurhonen]

Logic needs some fine tuning since highlighting of first field of deeply nested section (which ancestor is a required property) doesn't work.

In example schema, Design is required property and therefore it needs data to pass validation.

Example in deeply nested field that should be required:

In above image user has selected Pool as Sample Reference. In this case first field of child section should be required.

If user chooses Invidual Sample from options, highlighting works since first field gets required property.

Also, duplicate heading for Pool doesn't look right in design perspective. It works as should if checked against schema.

[hannyle]

@saulipurhonen I kinda fixed the issue with requiring and highlighting the first field of deeply nested object. I also fixed for some fields that are not required originally but still highlighted.

There are still some kinds of error with oneOf field (I guess) especially with Analysis object that even though I filled everything the form couldn't submit. We can investigate this more.

[hannyle]

So the issue was actually traverseFields object argument in FormOneOfFied.
It's good that you noticed this.