Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/e2e fix updated schemas #246

Merged
merged 4 commits into from
Apr 22, 2021
Merged

Conversation

blankdots
Copy link
Contributor

Description

Related issues

CSCfi/metadata-submitter#217

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Changes Made

  1. update analysis test for new structure
  2. add files to test

Testing

  • Integration Tests

Mentions

last commit with the branch will be removed once CSCfi/metadata-submitter#217 is merged, now just there for testing purposes

@blankdots blankdots added this to the Beta - User Interaction milestone Apr 13, 2021
@blankdots blankdots self-assigned this Apr 13, 2021
@blankdots blankdots marked this pull request as draft April 13, 2021 09:00
@blankdots blankdots force-pushed the feature/e2e-fix-updated-schemas branch from 75d6e1e to a4e32b4 Compare April 13, 2021 16:52
@blankdots blankdots force-pushed the feature/e2e-fix-updated-schemas branch from 1178361 to aadc9dc Compare April 19, 2021 08:17
@blankdots
Copy link
Contributor Author

changes related to schema changes fixed. Edit however does not work properly.

@blankdots blankdots force-pushed the feature/e2e-fix-updated-schemas branch from aadc9dc to 87ae520 Compare April 19, 2021 10:10
@blankdots
Copy link
Contributor Author

blankdots commented Apr 19, 2021

i suggest we review this as is and fix editing issues in #256

@blankdots blankdots marked this pull request as ready for review April 19, 2021 10:43
@blankdots blankdots requested review from hannyle and lilachic April 19, 2021 10:43
@blankdots blankdots force-pushed the feature/e2e-fix-updated-schemas branch from 87ae520 to b16c2c0 Compare April 22, 2021 05:34
@blankdots blankdots merged commit 2420ee5 into develop Apr 22, 2021
@blankdots blankdots deleted the feature/e2e-fix-updated-schemas branch April 22, 2021 05:41
@blankdots blankdots mentioned this pull request Aug 11, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants