Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add async validation and some improvements to xml upload #19

Merged
merged 15 commits into from
Jul 13, 2020
Merged

Feature/add async validation and some improvements to xml upload #19

merged 15 commits into from
Jul 13, 2020

Conversation

otahontas
Copy link
Contributor

@otahontas otahontas commented Jul 13, 2020 •
edited
Loading

Description

Adding some improvements to xml uploads.

Related issues

Fixes #16 #14

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Changes Made

  • Make form to validate file before submitting via backends /validate -endpoint
  • DIsable saving when there are errors in xml file
  • Add better error messages, unify all error messages to Formik stata
  • Notify user after 5 seconds, if saving to database takes time.
  • Some other small fixes

Testings

Tested manually, but needs unit tests and end-to-end tests at some point.

  • Needs testing (start an issue or do a follow up PR about it)

blankdots and others added 13 commits June 26, 2020 15:06
@blankdots
Merge pull request #13 from CSCfi/develop
8d288c0 
Develop
@otahontas
Fix development environment related proxy bugs
470596d
@otahontas
Add check for backend connection, report to user
24f42db
@otahontas
Add first version of async xml form validation
f76d542
@otahontas
Add .idea to .gitignore, fix some typos
cb8dc65
@otahontas
Stylish file select buttons, remove formik-material-ui lib
d730c8c 
We should instead use custom components, since our use cases are special.
@otahontas
Add more stylings to file input
da95bbf
@otahontas
Add proper error messages for file input, disable submit on errors
78cc611
@otahontas
Move file field validation to one function, remove yup
d4383bb
@otahontas
Move server related error messages to formik state, fix success handling
2f9d264
@otahontas
Fix some code stylings
88dfd16
@otahontas
Add info about server taking long time to respond
1162635
@otahontas
Fix type hint errors, force flow check on pre-commit hook
c374770
@otahontas otahontas changed the base branch from develop to master July 13, 2020 06:25
@otahontas otahontas changed the base branch from master to develop July 13, 2020 06:25
@otahontas otahontas requested a review from blankdots July 13, 2020 06:27
@otahontas otahontas self-assigned this Jul 13, 2020
blankdots
blankdots approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems much nicer. Just one small note from my vs-code:
image
also there are some typescript imports ... are we going typescript ?

@otahontas
Copy link
Contributor Author

otahontas commented Jul 13, 2020 •
edited
Loading

LGTM and seems much nicer. Just one small note from my vs-code:
image
also there are some typescript imports ... are we going typescript ?

Flow also supports interfaces. I believe that notification is caused by vscodes internal typescript checker.

Probably related: https://stackoverflow.com/questions/48859169/js-types-can-only-be-used-in-a-ts-file-visual-studio-code-using-ts-check

@otahontas
Allow files to be uploaded without mouse
46a7368 
This approach still has some rough edges, adding issue about that.
@blankdots blankdots merged commit 8a3be04 into develop Jul 13, 2020
@blankdots blankdots deleted the feature/add-async-validation branch July 13, 2020 09:15
@otahontas otahontas mentioned this pull request Aug 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankdots blankdots blankdots approved these changes

Assignees

@otahontas otahontas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otahontas @blankdots