Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codeQL and firefox to e2e tests #111

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Add codeQL and firefox to e2e tests #111

merged 3 commits into from
Dec 8, 2020

Conversation

blankdots
Copy link
Contributor

@blankdots blankdots commented Dec 8, 2020 •
edited
Loading

Description

add codeql for javascript and firefox to e2e tests

Related issues

#10

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  1. ignore .github folder from checks
  2. add codeql checks for vulnerabilities
  3. add firefox to e2e somehow lost

Testing

  • Tests do not apply

@blankdots blankdots self-assigned this Dec 8, 2020
@blankdots blankdots changed the base branch from develop to master December 8, 2020 10:43
@blankdots blankdots changed the base branch from master to develop December 8, 2020 10:44
saulipurhonen
saulipurhonen approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@saulipurhonen saulipurhonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@blankdots blankdots merged commit f3c669b into develop Dec 8, 2020
@blankdots blankdots deleted the feature/add-codeql branch December 8, 2020 12:04
@blankdots blankdots mentioned this pull request Dec 31, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulipurhonen saulipurhonen saulipurhonen approved these changes

@csc-jm-zz csc-jm-zz Awaiting requested review from csc-jm-zz

Assignees

@blankdots blankdots

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blankdots @saulipurhonen