Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: update pre-commit and run on all files #161

Merged
merged 7 commits into from
Mar 15, 2021
Merged

Conversation

maximlt
Copy link
Collaborator

@maximlt maximlt commented Mar 15, 2021

  • pre-commit config file updated
  • flake8 args moved from the pre-commit config file to setup.cfg
  • isort config fixed to be compatible with black (new param required for isort >= 5)
  • pre-commit ran over all the files (add a missing module docstring and reformatted a long string)
  • flake8 tox env replaced by a linters env that runs pre-commit

@maximlt
Copy link
Collaborator Author

maximlt commented Mar 15, 2021

#159 requires this PR to be merged to add the pre-commit action.

All the tests ran file locally with this new pre-commit config.

@sbrunato sbrunato changed the title Update pre-commit and run on all files lint: update pre-commit and run on all files Mar 15, 2021
@sbrunato sbrunato merged commit 5bcc431 into develop Mar 15, 2021
@maximlt maximlt deleted the update-precommit branch March 15, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants