Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Changes necessary to deploy React build #258

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

SomeMoosery
Copy link
Member

No issue as these are necessary fixes that needed to be completed on the spot for the build to deploy to S3.

@SomeMoosery SomeMoosery requested review from tesla809 and liadove March 28, 2020 01:53
@tesla809
Copy link
Contributor

Type error causing CI tests to fail.

Error messages pop up:

Error: Uncaught [TypeError: Cannot read property 'dataSample' of undefined]

TypeError: Cannot read property 'dataSample' of undefined
> 8 | const dataSample = useSelector(state => state.root.dataSample);

@SomeMoosery
Copy link
Member Author

We can leave this open until it's resolved, but I think this is an error with our current package management. Even a fresh install of master fails these tests now.

I think we should be more diligent about ensuring everyone is using yarn, and that every PR is rebased off the most current master. Babel 7.8.7 has been sneaking back in constantly, and will break tests/builds as it was a broken release

@tesla809
Copy link
Contributor

Great points @SomeMoosery. Working on the CONTRIBUTING.md and adding the language around rebasing off the current master.

I will add the information to alert the devs only to use Yarn.

@SomeMoosery
Copy link
Member Author

Actually, while it's good we stay up to date in our package.json of course, this also looks to be a more systemic problem. It's create-react-app's pinned issue right now

@SomeMoosery SomeMoosery merged commit fe9c766 into master Mar 28, 2020
@SomeMoosery SomeMoosery deleted the HOTFIX-react-build branch March 28, 2020 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants