Add wheel angular speed #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changing description of existing signal, but semantics should be the same. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
|
MoM:
|
|
MoM:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678
Related to #677
I suggest that we add a new signal rather than "refactoring" the old, as there might be use-cases where linear speed is useful, like if you have a passive TPMS system (and different wheel sizes) or if you use the average speed of individual wheels) with different size) to calculate
Vehicle.SpeedAlso changing description of existing signal, but semantics should be the same.
I used
degrees/sas unit as that is the only unit we currently have for angular velocity.As I see it it would not be a problem for us to add
radandrad/sto the list of supported units and userad/sif we prefer that.While discussing angular/rotation-speed it can also be worth mentioning that as of today we have two different quantities:
angular-speed(supported unitdegrees/s)rotational-speed(supported unitrpm)Do we see a need to keep both quantities; cannot
rpmalso be considered as a form of angular speed, and at least for something rotating with constant speed it is easy to convert betweendegrees/sandrpm.