Update allowed.md #565
Merged
Update allowed.md #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve clarity of example by introducing a value that is easily recognized as not belonging in the 'allowed' list.
erikbosch
requested changes
Mar 20, 2023
There was a problem hiding this comment.
Looks ok, but the "signed-off" in the commit (required according to https://www.covesa.global/contribute) seems to be missing
|
Meeting notes: OK to merge when signoff added |
|
Signed-off-by: Neil Puthuff neil@rti.com |
|
I realized that the contribution guidelines in https://www.covesa.global/contribute are a bit ambiguous - is it the PR or commit (by e.g. |
|
Sign-off briefly discussed in data expert group. Opinion seems to be that sign-off should be on commit. @neil-rti - if you do a git |
Improve clarity of example by introducing a value that is easily recognized as not belonging in the 'allowed' list. Signed-off-by: Neil Puthuff <neil@rti.com>
|
Meeting notes: Ready to merge |
jdacoello
pushed a commit
to jdacoello/vehicle_signal_specification
that referenced
this pull request
May 2, 2023
* Update allowed.md Improve clarity of example by introducing a value that is easily recognized as not belonging in the 'allowed' list. Signed-off-by: Neil Puthuff <neil@rti.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve clarity of example by introducing a value that is easily recognized as not belonging in the 'allowed' list.