Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Power Optimize concept #528

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

erikbosch
Copy link
Collaborator

This is a power optimization concept based on discussions in the COVESA power optimization project

@erikbosch
Copy link
Collaborator Author

Meeting notes:

  • To be discussed at power optimize meeting tomorrow

@UmangSharmaMobis
Copy link
Contributor

UmangSharmaMobis commented Feb 6, 2023

Please find power optimization group meeting update:

  1. The signal can be added to a branch by including this file, like:
    #include include/PowerOptimize.vspec
    so that also full fill the requirement of upcoming signal.
  2. after reviewing the given code, all members agree that it seems fit to merge. can proceed further.

datatype: uint8
type: actuator
min: 1
max: 10
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meeting notes: Info from EV Power optimize group, shall be refactored, 0 =no power optimize, 10= maximum. If redefined no problem to be merged.

Way forward:

  • Erik to update PR
  • Mobis/Umang to review after change
  • If OK, Erik can merge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated, @UmangSharmaMobis please review

@erikbosch erikbosch force-pushed the erikbosch/erik_power branch from 064bb73 to 0e85c76 Compare February 8, 2023 13:34
This is a power optimization concept based on discussions in the
COVESA power optimization project

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
@erikbosch erikbosch force-pushed the erikbosch/erik_power branch from 0e85c76 to 94e8b3d Compare February 8, 2023 14:26
Copy link
Contributor

@UmangSharmaMobis UmangSharmaMobis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given definition is fine. it can be merge.

@erikbosch erikbosch merged commit 28dcd2d into COVESA:master Feb 9, 2023
@erikbosch erikbosch deleted the erikbosch/erik_power branch February 9, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants