Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tire pressure unit to HMI #501

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Add tire pressure unit to HMI #501

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
856376a
Add tire pressure unit to HMI
wonsuk73 Oct 25, 2022
4ddf76b
Fix syntax error
wonsuk73 Oct 25, 2022
19adbd8
Replace allowed value strings with upper case
wonsuk73 Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spec/Cabin/Infotainment.vspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,12 @@ HMI.TemperatureUnit:
type: actuator
allowed: ['C', 'F']
description: Temperature unit used in the current HMI

HMI.TirePressureUnit:
datatype: string
type: actuator
allowed: [‘psi’, ‘kPa’, ’bar’]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the signal makes sense, it is similar to other signals in this file. What needs to be discussed is the values to use; shall we use "real abbreviation" like currently proposed, or something more enum-like as in existing signals. In https://covesa.github.io/vehicle_signal_specification/rule_set/data_entry/allowed/#recommendation-on-string-values we suggest to only use upper case (and numbers), but as we here are concerned with "real abbreviations" I see that this actually could be an OK exception. But I would like to get comments from others - do we want to keep it as is or do we prefer for example:

allowed: [‘PSI’, ‘KPA’, ’BAR’]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikbosch Thanks for quick review and good comment! I prefer to use upper case only like other signals. But as you said let's see the comments from others.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meeting decision: Valid proposal, using upper case preferred, please update PR using upper case.
If updated and no objections received ready to be merged on next meeting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikbosch Thanks! I have done the upper case changes.

Copy link
Collaborator

@adobekan adobekan Oct 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikbosch We have mixture of abbreviation and full names.

Probably it is easier to have complete names for developers, but current proposal i think it should be fine as well

description: Tire pressure unit used in the current HMI

HMI.DayNightMode:
datatype: string
Expand Down