-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving charging and battery signals #442
Conversation
At the meeting yesterday there were a question on backward incompatible changes, here I try to summarize them including a rationale:
|
Id: | ||
datatype: string | ||
type: attribute | ||
description: Battery Identification Number as assigned by OEM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this ID meant to represent? Some serial number? A location in the vehicle? A differentiator in case there are more than one batteries in the vehicle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description could be improved, the intention is not to specify that this is battery "2" in the vehicle, but rather a (more or less) unique identifier of the battery instance mounted in the vehicle. E.g. serial number, UUID, part_number+serial_number or similar.
As far as I know there are no standard similar to Vehicle Identification Number (VIN) that assures that battery identifiers are globally unique, but I assume that the id (possibly combined with part number) makes it posssible to identify exactly which battery which is mounted.
I will double check with my colleagues and propose an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment to clarify that it concerns a "unique" identifier. But the level of uniqueness is up to the OEM.
This PR contains various improvement suggestions to battery and charging signals. Major changes: - Battery identifiers added - Extension of temperature signals - State of health signal added - NetCapacity changed to sensor - Many Charging signals refactored to allow separate measurements for each phase. - ChargePlugType now use an array, as vehicles mioght have multiple charge plugs - Some signals for power loss (to heat) added
f93b8ab
to
1273c36
Compare
Decision to merge 2022/05/24 |
This PR contains various improvement suggestions to battery and charging signals.
Major changes: