Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving charging and battery signals #442

Merged
merged 1 commit into from
May 24, 2022

Conversation

erikbosch
Copy link
Collaborator

This PR contains various improvement suggestions to battery and charging signals.

Major changes:

  • Battery identifiers added
  • Extension of temperature signals
  • State of health signal added
  • NetCapacity changed to sensor
  • Many Charging signals refactored to allow separate measurements for each phase.
  • ChargePlugType now use an array, as vehicles mioght have multiple charge plugs
  • Some signals for power loss (to heat) added

@erikbosch
Copy link
Collaborator Author

At the meeting yesterday there were a question on backward incompatible changes, here I try to summarize them including a rationale:

  • Vehicle.Powertrain.TractionBattery.Temperature was previously a sensor-signal, now a branch to contain 3 temperature signals Min, Max and Average as a battery pack often have multiple temperature sensors, and it was ambiguous what the old sensor value actually meant, i.e. did it refer to avergae temperature or the maximum temperature?
  • Vehicle.Powertrain.TractionBattery.StateOfCharge.Target removed , considered to be the same as Vehicle.Powertrain.TractionBattery.Charging.ChargeLimit, i.e. we could not identify any use-case where both are needed/used
  • Vehicle.Powertrain.TractionBattery.ReferentVoltage removed. We had problems finding a definition for what is meant with referent voltage and how it differs from nominal voltage. We already have Vehicle.Powertrain.TractionBattery.NominalVoltage, and propose a new signal Vehicle.Powertrain.TractionBattery.MaxVoltage
  • Vehicle.Powertrain.TractionBattery.Charging.ChargePlugType has type changed to string[]. Reason is that a vehicle may have multiple plugs/inlets.
  • Vehicle.Powertrain.TractionBattery.Charging.ChargeCurrent and Vehicle.Powertrain.TractionBattery.Charging.ChargeVoltage converted from sensors to branches. The old signals were ambiguous as they did not state if the value was as measured at the charge plug/inlet, or as measured at the battery. Now separate signals has been created for values at charge inlet and at battery, like Vehicle.Powertrain.TractionBattery.CurrentCurrent and Vehicle.Powertrain.TractionBattery.Charging.ChargeCurrent.DC. For charge current separate signals are introduced for DC and AC phases.

Id:
datatype: string
type: attribute
description: Battery Identification Number as assigned by OEM.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this ID meant to represent? Some serial number? A location in the vehicle? A differentiator in case there are more than one batteries in the vehicle?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description could be improved, the intention is not to specify that this is battery "2" in the vehicle, but rather a (more or less) unique identifier of the battery instance mounted in the vehicle. E.g. serial number, UUID, part_number+serial_number or similar.

As far as I know there are no standard similar to Vehicle Identification Number (VIN) that assures that battery identifiers are globally unique, but I assume that the id (possibly combined with part number) makes it posssible to identify exactly which battery which is mounted.

I will double check with my colleagues and propose an update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to clarify that it concerns a "unique" identifier. But the level of uniqueness is up to the OEM.

This PR contains various improvement suggestions to battery and charging signals.

Major changes:
- Battery identifiers added
- Extension of temperature signals
- State of health signal added
- NetCapacity changed to sensor
- Many Charging signals refactored to allow separate measurements for each phase.
- ChargePlugType now use an array, as vehicles mioght have multiple charge plugs
- Some signals for power loss (to heat) added
@erikbosch erikbosch force-pushed the erikbosch/erik_battery branch from f93b8ab to 1273c36 Compare May 16, 2022 07:33
@danielwilms
Copy link
Collaborator

Decision to merge 2022/05/24

@danielwilms danielwilms merged commit b2dc5ef into COVESA:master May 24, 2022
@erikbosch erikbosch deleted the erikbosch/erik_battery branch June 20, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants