CMakeLists.txt: make DLT_WatchdogSec can be set by user #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my test env, WatchdogSec default value 2 is not enough, manually changed to 3 is ok. This makes dlt.service/dlt-system.service start failed during boot time. So, make DLT_WatchdogSec can be set by user, so user can set them to proper value at build time, then service can start successfully in boot time. Signed-off-by: Changqing Li <changqing.li@windriver.com>
| @@ -18,10 +18,14 @@ if(WITH_SYSTEMD) | |||
| set(SYSTEMD_CONFIGURATIONS_FILES_DIR ${SYSTEMD_UNITDIR} ) | |||
|
|
|||
| if(WITH_SYSTEMD_WATCHDOG) | |||
| set( DLT_WatchdogSec 2 ) | |||
| if(NOT DEFINED DLT_WatchdogSec) | |||
There was a problem hiding this comment.
Hi @Le-Tin This change will not impact to our current source code.
Also, It offer flexibility for user to define their custom DLT_WatchdogSec .
So i agree to merge this change.
lti9hc
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
thanks for your contribution @sandy-lcq
thanks for your review @Bichdao021195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my test env, WatchdogSec default value 2 is not enough, manually changed to 3 is ok. This makes dlt.service/dlt-system.service start failed during boot time. So, make DLT_WatchdogSec can be set by user, so user can set them to proper value at build time, then service can start successfully in boot time.