dlt-receive: add reconnect option

[maiananthan]

Issue

• When dlt-receive is not connected to dlt-daemon, dlt-receive process is getting ended.

Fix

• Added a option (-r) to reconnect dlt-daemon automatically.
• Added a option value which can be mentioned as milli seconds as user input.

[minminlittleshrimp]

Hello @maiananthan
thank you.
So it's actually not a bug, but a feature/enhancement.
I'm fine with the point to hang the dlt-client like this, but could you kindly explain a little bit about the purpose?
IMO, dlt client should stop immediately when daemon down, since the pipe/socket closed and nothing further to send/flush to client.
Regards

[minminlittleshrimp]

Hello @maiananthan thank you. So it's actually not a bug, but a feature/enhancement. I'm fine with the point to hang the dlt-client like this, but could you kindly explain a little bit about the purpose? IMO, dlt client should stop immediately when daemon down, since the pipe/socket closed and nothing further to send/flush to client. Regards

Sorry not reading carefully, so I suppose I am a user and would rather the client side stay there when I do something like reboot daemon, I think it is good to hang awhile. My concern is:

1. What is the timeout, client should not stay forever!!!?
2. This is only applied for dlt-receive, so we cannot say that this is applicable for other clients, so in fact this not a bug, but enhancement for dlt-receive

I am fine with merging this patch. Let see @michael-methner opinion.

[minminlittleshrimp]

Should the loop stop here? If not, the loop goes on forever!

[minminlittleshrimp]

I suggest my fix, which I applied and checked that it works:

$ git df
diff --git a/src/console/dlt-receive.c b/src/console/dlt-receive.c
index ad42e42..58bc0b3 100644
--- a/src/console/dlt-receive.c
+++ b/src/console/dlt-receive.c
@@ -637,14 +637,15 @@ int main(int argc, char *argv[])
                 // if reconnect flag is enabled, wait for mentioned milli
                 // seconds
                 poll(NULL, 0, dltdata.rvalue);
-                continue;
-            }
-            else {
-                /* Dlt Client Cleanup */
-                dlt_client_cleanup(&dltclient, dltdata.vflag);
+                //continue;
                 break;
             }
         }
+        else {
+            /* Dlt Client Cleanup */
+            dlt_client_cleanup(&dltclient, dltdata.vflag);
+            break;
+        }
     } while (dltdata.rflag == 1 && poll(NULL, 0, dltdata.rvalue) == 0);
 
     /* dlt-receive cleanup */

[michael-methner]

Please make the wording more precise: "Reconnect to server after milli seconds"

[michael-methner]

this is somehow duplicated to the poll instruction before. You could use a while(1) instead.

I would prefer sleep() or nanosleep() instead of the poll to implement a sleep function.

[minminlittleshrimp]

Hello @maiananthan
Kindly update the patch for review and merge.
Thank you a lots.

[duvanan13]

Duplicated by #640