Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlt: Add IPv6 gateway and refactor cmake unittest #596

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

minminlittleshrimp
Copy link
Collaborator

cmake: correct typo in setting up evironment

unittest: pgrep should detect the exact pattern

cmake: refactor wrong line continuation

unittest: adapt IPv6 testing

  • Checking NULL before checking IP
  • Add environment variable for default loopback IP
  • Add test for IPv6 in unittest, by using converted IP
  • Add correct IP protocol for testing to dlt_gateway.conf

@michael-methner
Copy link
Collaborator

Hello @minminlittleshrimp ,
i am fine with the changes but could you please add a proper commit message. It should describe what's in the patch not from whom it is coming.

The patch includes:

cmake: correct typo in setting up evironment

Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>

unittest: pgrep should detect the exact pattern

Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>

cmake: refactor wrong line continuation

Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>

unittest: adapt IPv6 testing

+ Checking NULL before checking IP
+ Add environment variable for default loopback IP
+ Add test for IPv6 in unittest, by using converted IP
+ Add correct IP protocol for testing to dlt_gateway.conf

Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>
@minminlittleshrimp minminlittleshrimp force-pushed the dlt_devel_refactor_unittest_cmake branch from 07ed62c to 4eec34e Compare February 14, 2024 09:48
@minminlittleshrimp minminlittleshrimp changed the title Upstream from BOSCH dlt-daemon dlt: Add IPv6 gateway and refactor cmake unittest Feb 14, 2024
@minminlittleshrimp
Copy link
Collaborator Author

Hello @minminlittleshrimp , i am fine with the changes but could you please add a proper commit message. It should describe what's in the patch not from whom it is coming.

Hello @michael-methner
kindly review, I already edit the commit title.
Thank you.

@michael-methner michael-methner merged commit a465513 into master Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants