Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Custom signing keys per request #26

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Custom signing keys per request #26

merged 1 commit into from
Jul 25, 2017

Conversation

TimDaub
Copy link

@TimDaub TimDaub commented May 6, 2017

@vrde would be great if you could take a look. I'll leave it to you to click the merge button

@TimDaub TimDaub requested a review from vrde May 6, 2017 15:52
vrde
vrde suggested changes May 8, 2017
View reviewed changes
Copy link

@vrde vrde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to re-introduce the endpoint to generate a keypair. Can you checkout it from upstream?

Also, resolve conflicts pls :)

@TimDaub TimDaub mentioned this pull request May 8, 2017
Merged
@TimDaub TimDaub force-pushed the authentication-update branch from 685947b to 33f387a Compare July 25, 2017 08:20
@TimDaub TimDaub merged commit 312fe4a into master Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrde vrde vrde requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimDaub @vrde