Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates for v1.1 release #51

Merged
merged 4 commits into from
Jan 30, 2025
Merged

updates for v1.1 release #51

merged 4 commits into from
Jan 30, 2025

Conversation

JamesAnstey
Copy link

added checks that BCVs always included

@JamesAnstey JamesAnstey mentioned this pull request Jan 30, 2025
Open
@JamesAnstey JamesAnstey changed the title draft: updates for v1.1 release updates for v1.1 release Jan 30, 2025
wolfiex
wolfiex approved these changes Jan 30, 2025
View reviewed changes
Copy link

@wolfiex wolfiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tried running, but the changes seem sensible.

matthew-mizielinski
matthew-mizielinski approved these changes Jan 30, 2025
View reviewed changes
Copy link

@matthew-mizielinski matthew-mizielinski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider dropping the del statements in dreq_query.py, but this won't have any impact on the results.

LGTM

@JamesAnstey JamesAnstey merged commit 5abfe97 into main Jan 30, 2025
0 of 32 checks passed
@JamesAnstey JamesAnstey deleted the v1.1rc_updates branch January 30, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfiex wolfiex wolfiex approved these changes

@matthew-mizielinski matthew-mizielinski matthew-mizielinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesAnstey @matthew-mizielinski @wolfiex