Add support in the MapBinner for per-scan (or sub-obs) map-making. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new parameter (map_per_scan) to the map binner that can control when maps are emitted. If defaults to False, preserving existing behavior. If set to True, or to a callable that returns True, it will result in the in-progress map being flushed to the data stream. This enables simple creation of per-scan maps (set to True) or more complex bundlings (with a callable).
kferguson42
reviewed
Mar 11, 2022
| " this case, the callable will be called on each Scan frame and passed \n" | ||
| " the frame as an argument. If it returns True, the map binner will emit \n" | ||
| " a map frame with the data since the last emitted map frame but *before* \n" | ||
| " the current Scan; if False, the binner will continue accumulating data.\n" |
There was a problem hiding this comment.
In the callable case, doesn't it make more sense to include the current Scan frame instead of emitting only everything that came before?
There was a problem hiding this comment.
The idea is that this indicates the start of new data, which is easier to detect than the end of old data since you don't have to know the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter (map_per_scan) to the map binner that can
control when maps are emitted. If defaults to False, preserving existing
behavior. If set to True, or to a callable that returns True, it will
result in the in-progress map being flushed to the data stream. This
enables simple creation of per-scan maps (set to True) or more complex
bundlings (with a callable).