Make FlattenPol set flat_pol attribute of T maps and weights #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlattenPolsets theflat_polattribute of QU maps and weights to keep track of whether a frame has been flattened, but does not set this attribute for T maps and weights. WhileFlattenPoldoes not affect T, a frame's T map is often used as a "stub" containing metadata for the generation of subsequent data products. As a result, polarized data products generated from a T stub will not inherit theflat_polattribute as one might expect. After discussion with @arahlin, we decided to makeFlattenPolmodifyflat_polfor T as well as Q and U.