Timestream serialization speed #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 17, 2023 16:38
This is unnecessary as G3Frame protects all serialized data with a CRC, and removing it greatly decreases the time to serialize compressed waveforms.
This avoids pointless double conversion for several of the possible storage types.
|
I think @tskisner will have to speak to how useful this is for his purposes; as noted it doesn't directly do anything to help non- |
marius311
pushed a commit
to marius311/spt3g_software_public
that referenced
this pull request
Aug 15, 2023
--------- Co-authored-by: Tyler Natoli <tnatoli@amundsen.grid.uchicago.edu> Co-authored-by: Alexandra Rahlin <arahlin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes roughly double the speed at which large amounts of integer timestream data can be serialized, and should provide much of that benefit to more common floating-point data, as well.