Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate code with multi-stage builds #44

Closed
wants to merge 5 commits into from
Closed

Removed duplicate code with multi-stage builds #44

wants to merge 5 commits into from

Conversation

mbenlioglu
Copy link
Contributor

Instead of having two separate Dockerfiles with only 1 line of difference, this PR combines them into one file. To build the images, we need to specify --target in the docker command, e.g.:

docker build --target bullseye -t steamcmd:bullseye -f bullseye/Dockerfile .
docker build --target bullseye-root -t steamcmd:bullseye-root -f bullseye/Dockerfile .

I believe this makes maintenance easier and overall better practice.

Also in this PR:

  • Updated hardcoded versions of nano, curl and locales, because apt-get install is failing during build
  • Removed wget. The only usage of it was to download steamcmd tarball, then it was removed with apt-get remove. Instead of that, I replaced wget -qO - with curl -fsSL which has the same desired effect.

@CM2Walki
Copy link
Owner

Good PR! In fact almost perfect PR, the only issue it had was that it broke Docker Hub's automated builds. I fixed that in #45. No worries, your contributions will of course show up in the repository even though this PR will be closed :).

Thanks for the contribution

@CM2Walki CM2Walki closed this in #45 Oct 23, 2022
@mbenlioglu
Copy link
Contributor Author

Glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants