Removed duplicate code with multi-stage builds #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having two separate Dockerfiles with only 1 line of difference, this PR combines them into one file. To build the images, we need to specify
--target
in the docker command, e.g.:I believe this makes maintenance easier and overall better practice.
Also in this PR:
apt-get install
is failing during buildapt-get remove
. Instead of that, I replacedwget -qO -
withcurl -fsSL
which has the same desired effect.